WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Live migration with MMIO pages

To: Kieran Mansley <kmansley@xxxxxxxxxxxxxx>, Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Live migration with MMIO pages
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Fri, 02 Nov 2007 10:42:07 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 02 Nov 2007 03:42:50 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1193995893.4327.55.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcgdPQOPQfBScIkwEdyrMQAX8io7RQ==
Thread-topic: [Xen-devel] Live migration with MMIO pages
User-agent: Microsoft-Entourage/11.3.6.070618
On 2/11/07 09:31, "Kieran Mansley" <kmansley@xxxxxxxxxxxxxx> wrote:

>> You could do that.  I think the correct test is shadow_mode_refcounts();
>> as Keir pointed out, guests whose refcounting isn't done by the shadow
>> code will have had their pagetables validated bby the PV MMU interface.
>> 
>> The test around the log-dirty code can just be on mfn_valid().
> 
> Attached is a new patch with those changes.  Seems much more sensible to
> me that way too, and it works just as well.

I changed the final chunk test from !shadow_mode_translate() to
shadow_mode_refcounts(). I think refcounts is a better test than translate
here, and also I think your test was the wrong way round!

I also note that guarding the mark-dirty-or-zap-writable-bit with
mfn_valid() is not really correct. mfn_valid() only checks whether the mfn <
max_page. I bet this would not work if you migrate on a machine with 4GB of
RAM, as the MMIO hole will be below max_page. Really mfn_valid needs to
handle such MMIO holes, or the shadow code needs to be using a test other
than mfn_valid in many places (e.g., the function iomem_page_test() that you
added before).

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel