WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel][VTD][PATCH][RESEND]add a timer for the sharedinterrupt i

To: "Xin, Xiaohui" <xiaohui.xin@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel][VTD][PATCH][RESEND]add a timer for the sharedinterrupt issue for vt-d
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Sat, 20 Oct 2007 12:24:03 +0100
Delivery-date: Sat, 20 Oct 2007 04:19:27 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <9A1462408D6D394C8A7A812E98F00A4D0226ACE5@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcgQw+ProgCV0z3VTpKlJoAxcNdgrQApmSLpACXmX1AADhg+kgAzHlZQAAE+5vI=
Thread-topic: [Xen-devel][VTD][PATCH][RESEND]add a timer for the sharedinterrupt issue for vt-d
User-agent: Microsoft-Entourage/11.3.6.070618
On 20/10/07 12:04, "Xin, Xiaohui" <xiaohui.xin@xxxxxxxxx> wrote:

For 2) Yes, firstly I think to use the flag of the domain as “is_pasued_by_controller”, but from the experience and from the log file, at the situation which IDE shares interrupt with NIC card, and when the NIC is assigned to HVM guest, “is pasued_by_controller” can deal with most cases, but after unpaused, there are still one or more interrupts can be scheduled. The “is_paused_by_controller” can not deal with all the cases.  So I still use timer to deal with that because timer is simple.

How about setting the timer unconditionally in hvm_do_IRQ_dpci() (i.e., as you do now), but then not touching it at all in vmx_dirq_assist()? Is there much point in resetting the timer in vmx_dirq_assist()? It seems to me you should have an assert-to-eoi latency that you are prepared to tolerate. Does separating out assert-to-inject and inject-to-eoi latencies actually make sense?

 -- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel