WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] nr_cpus calculation problem due to incorrectsock

To: <eak@xxxxxxxxxx>, <Xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] nr_cpus calculation problem due to incorrectsockets_per_node
From: "Puthiyaparambil, Aravindh" <aravindh.puthiyaparambil@xxxxxxxxxx>
Date: Fri, 19 Oct 2007 12:22:43 -0500
Delivery-date: Fri, 19 Oct 2007 10:33:32 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <4718C36F.5090607@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4718C36F.5090607@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcgSXxEjg6UNFIL4Sd+9hnk+eMdW/AAFJyWw
Thread-topic: [Xen-devel] [PATCH] nr_cpus calculation problem due to incorrectsockets_per_node
Beth,

With this patch you are able to come up with 128 logical CPUs on x86_64
Xen? I.E you did a compile with max_phys_cpus=128 and successfully
booted? Don't you need to also increase NR_RESERVED_GDT_PAGES based on
number of CPUs among other things?

Thanks,

Aravindh Puthiyaparambil 
Virtualization Engineer
Virtual Systems Development
Unisys, Tredyffrin PA

-----Original Message-----
From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
[mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of beth kon
Sent: Friday, October 19, 2007 10:47 AM
To: Xen-devel@xxxxxxxxxxxxxxxxxxx; xen-ppc-devel@xxxxxxxxxxxxxxxxxxx;
xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] nr_cpus calculation problem due to
incorrectsockets_per_node

Testing on an 8-node 128-way NUMA machine has exposed a problem with 
Xen's nr_cpus calculation. In this case, since Xen cuts off recognized 
CPUs at 32, the machine appears to have 16 CPUs on the first and second 
nodes and none on the remaining nodes. Given this asymmetry, the 
calculation of sockets_per_node (which is later used to calculate 
nr_cpus) is incorrect:

pi->sockets_per_node = num_online_cpus() /(num_online_nodes() * 
pi->cores_per_socket * pi->threads_per_core);

The most straightforward solution is to remove sockets_per_node, and 
instead determine nr_cpus directly from num_online_cpus.

This patch has been tested on x86_64 NUMA machines.

-- 
Elizabeth Kon (Beth)
IBM Linux Technology Center
Open Hypervisor Team
email: eak@xxxxxxxxxx


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel