 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] Double mapping of iomem assertion
| To: | Jan Beulich <jbeulich@xxxxxxxxxx>, Kieran Mansley <kmansley@xxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] Double mapping of iomem assertion |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Fri, 19 Oct 2007 08:19:24 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Fri, 19 Oct 2007 00:14:53 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <4718753D.76E4.0078.0@xxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcgSIGAQnl3+sH4TEdyStQAWy6hiGQ== |
| Thread-topic: | [Xen-devel] Double mapping of iomem assertion |
| User-agent: | Microsoft-Entourage/11.3.6.070618 |
On 19/10/07 08:13, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote: >> This was introduced by xen changeset 14731, back in April. So Jan is to >> blame (and me, I suppose!). ;-) I expect it's in a few vendor kernels at >> this point... > > Indeed, I didn't consider this situation. However, excluding the check > against current->mm here was on purpose (and hence I'm not certain > your adding of it was correct) - when used on user mappings, > ptep_get_and_clear() is expected to return the most up-to-date A/D > flags, which cannot be achieved through a hypercall. On the contrary, > the use(s) with init_mm never have such expectations as far as I > recall, they at best check the returned value for validity/presence/null. Ah, that's true... I'll fix the fix. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] Double mapping of iomem assertion, Jan Beulich |
|---|---|
| Next by Date: | Re: [Xen-devel] the ptwr cmpxchg fix, Keir Fraser |
| Previous by Thread: | Re: [Xen-devel] Double mapping of iomem assertion, Jan Beulich |
| Next by Thread: | [Xen-devel][VTD][RESEND]add a timer for the shared interrupt issue for vt-d, Xin, Xiaohui |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
