 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] unregister_xenbus_watch() handling of xenwatch_mutex
| To: | Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] unregister_xenbus_watch() handling of xenwatch_mutex |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Thu, 18 Oct 2007 13:12:39 +0100 |
| Cc: | Jeremy Fitzhardinge <jeremy@xxxxxxxxxxxxx> |
| Delivery-date: | Thu, 18 Oct 2007 05:13:46 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <471761F0.76E4.0078.0@xxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcgRgC0Wa1yfOH1zEdyymgAX8io7RQ== |
| Thread-topic: | [Xen-devel] unregister_xenbus_watch() handling of xenwatch_mutex |
| User-agent: | Microsoft-Entourage/11.3.6.070618 |
That's a question for Jeremy. I think the 2.6.18 version is equally correct and only needs one if statement. Maybe hoisting the lock acquisition gave Jeremy a warmer fuzzy feeling? :-) -- Keir On 18/10/07 12:38, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote: > 2.6.23 acquires the mutex before canceling pending events, whereas > linux-2.6.18-xen acquires and releases the mutex back-to-back after > doing the cancellation. It would seem to me that the former method is > more robust, but otoh I'm wondering why this change then wasn't also > made in the 2.6.18 tree. > > Thanks, Jan > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@xxxxxxxxxxxxxxxxxxx > http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] unregister_xenbus_watch() handling of xenwatch_mutex, Jan Beulich |
|---|---|
| Next by Date: | [Xen-devel] c/s 15147 change to struct vcpu_register_vcpu_info, Jan Beulich |
| Previous by Thread: | [Xen-devel] unregister_xenbus_watch() handling of xenwatch_mutex, Jan Beulich |
| Next by Thread: | Re: [Xen-devel] unregister_xenbus_watch() handling of xenwatch_mutex, Jeremy Fitzhardinge |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
