WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] xenbus_dev_request_and_reply() checking for transaction end

To: "Jeremy Fitzhardinge" <jeremy@xxxxxxxxxxxxx>
Subject: [Xen-devel] xenbus_dev_request_and_reply() checking for transaction end
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Thu, 18 Oct 2007 12:30:03 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 18 Oct 2007 04:34:26 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Jeremy,

what is the motivation for doing

        if ((msg->type == XS_TRANSACTION_END) ||

where linux-2.6.18-xen does

        if ((req_msg.type == XS_TRANSACTION_END) ||

? Is the intention to continue holding the mutex if sending the transaction
end message fails? If so, wouldn't this also require all users of
xenbus_transaction_end() to do proper error checking *and* re-issuing?

Thanks, Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] xenbus_dev_request_and_reply() checking for transaction end, Jan Beulich <=