WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] cpufreq: weird bug in set_time_scale

To: "Langsdorf, Mark" <mark.langsdorf@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] cpufreq: weird bug in set_time_scale
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Thu, 11 Oct 2007 18:43:08 +0100
Delivery-date: Thu, 11 Oct 2007 10:38:58 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1449F58C868D8D4E9C72945771150BDF02077091@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcgMHynrWGtjBxvCTSCDYPX32f/mCwADwVLM
Thread-topic: [Xen-devel] cpufreq: weird bug in set_time_scale
User-agent: Microsoft-Entourage/11.3.6.070618
That's my code. I'll take a look!

 K.

On 11/10/07 16:55, "Langsdorf, Mark" <mark.langsdorf@xxxxxxx> wrote:

> On my test machine, in set_time_scale(),
> the following code:
> ts->mul_frac = div_frac(MILLISECS(1000), tps32);
> crashes with a division by zero error if
> tps32 == 1000000000d.  Unfortunately, tps32 is
> often that value.
> 
> Does anyone know why this happens?  I've
> resolved it temporarily by checking for
> tps32 == 1000000000 and changing the
> value slightly (101000010d works fine
> on my test machine), but I'm not sure
> if that's the approved approach for Xen.
> 
> -Mark Langsdorf
> Operating System Research Center
> AMD
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel