WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] PATCH: Fix name uniqueness check

Hi Dan,

Thanks for your effort and your patch. 
I think that the allow/reject rules are wonderful.  But, I have a few 
comments. 


I agree the rule of the following case. 
But, the behavior is (redefine+rename+create), isn't it?

>  - Scenario 2: xm create + existing inactive vm
>      c. diff name + same UUID:  ALLOW  (create)

# xm new /xen/vm1.conf uuid="11111111-2222-3333-4444-555555555555"
Using config file "/xen/vm1.conf".
# xm list
Name                                        ID   Mem VCPUs      State   Time(s)
Domain-0                                     0   941     2     r-----     85.0
vm1                                              256     1                 0.0
# xm create /xen/vm2.conf uuid="11111111-2222-3333-4444-555555555555"
Using config file "/xen/vm2.conf".
Started domain vm2
# xm list
Name                                        ID   Mem VCPUs      State   Time(s)
Domain-0                                     0   743     2     r-----     88.9
vm2                                          1   256     1     r-----      2.2
# cat /var/lib/xend/domains/11111111-2222-3333-4444-555555555555/config.sxp | 
grep name
    (name_label vm2)
    (name vm2)
            (uname file:/xen/root-vm2.img)
# xm shutdown vm2
# xm list
Name                                        ID   Mem VCPUs      State   Time(s)
Domain-0                                     0   743     2     r-----     95.9
vm2                                              256     1                32.0


When I tested the following case, the result was as follows. 
I think that we should reject xm new command if same UUID vm is active. 

>  - Scenario 3: xm new + existing active vm
>      c. diff name + same UUID:  ALLOW  (redefine+rename)

# xm create /xen/vm1.conf uuid="11111111-2222-3333-4444-555555555555"
Using config file "/xen/vm1.conf".
Started domain vm1
# xm list
Name                                        ID   Mem VCPUs      State   Time(s)
Domain-0                                     0   743     2     r-----    105.6
vm1                                          2   256     1     -b----      1.4
# xm new /xen/vm2.conf uuid="11111111-2222-3333-4444-555555555555"
Using config file "/xen/vm2.conf".
# xm list
Name                                        ID   Mem VCPUs      State   Time(s)
Domain-0                                     0   743     2     r-----    110.7
vm1                                          2   256     1     -b----     26.5
# xm start vm2
# xm list
Name                                        ID   Mem VCPUs      State   Time(s)
Domain-0                                     0   491     2     r-----    114.8
vm1                                          2   256     1     -b----     26.6
vm2                                          3   256     1     r-----     20.5
# xm list --long vm1 vm2 | grep uuid
    (uuid 11111111-2222-3333-4444-555555555555)
            (uuid ed6136f4-f140-fbdb-49db-861499cd54ad)
            (uuid 632ba398-1cfe-831f-cfdd-a5e1b92ae7c6)
            (uuid 028f4c5d-5850-0eda-e0b5-cde0f252be13)
    (uuid 11111111-2222-3333-4444-555555555555)
            (uuid 12427bbe-6120-a864-bb5b-56ed5f8d14c5)
            (uuid 56ba82ca-4a62-42e7-3eb7-b15578bf828b)

Best regards,
 Kan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel