 Home |
Products |
Support |
Community |
News |
xen-devel
[Xen-devel] Re: question on c/s 15964
| To: | Jan Beulich <jbeulich@xxxxxxxxxx> |
|---|---|
| Subject: | [Xen-devel] Re: question on c/s 15964 |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Thu, 27 Sep 2007 08:51:32 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Thu, 27 Sep 2007 00:47:23 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <46FB7189.76E4.0078.0@xxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcgA2zgndq7/2WzOEdykRgAWy6hiGQ== |
| Thread-topic: | question on c/s 15964 |
| User-agent: | Microsoft-Entourage/11.3.6.070618 |
On 27/9/07 08:02, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote: > in the new function reserve_e820_ram() you do nothing *and* return 0 (success) > if an entry would need to be split but there's no room. This seems dangerous > to > me; in the original version of the patch I had sent I truncated the entry > instead, > choosing the variant (start or end) that resulted in less loss of memory. Yes, that's probably a better option. Or lose entries from the end of the e820map (which is what silently happens if the BIOS offers more than 128 entries in the first place). Or perhaps just BUG_ON()? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH][RFC] making "xm dump-core" paralell, Keir Fraser |
|---|---|
| Next by Date: | Re: [Xen-devel] Reporting a traceback, Keir Fraser |
| Previous by Thread: | [Xen-devel] question on c/s 15964, Jan Beulich |
| Next by Thread: | [Xen-devel] Re: question on c/s 15964, Jan Beulich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
