WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [VTD][patch 1/1] vt-d hardware check

To: "Kay, Allen M" <allen.m.kay@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [VTD][patch 1/1] vt-d hardware check
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Sat, 22 Sep 2007 07:20:40 +0100
Delivery-date: Fri, 21 Sep 2007 23:16:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <13A2F7DE1BAEA345A61DD40F303ED7A6850CA3@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acf8qK+aNrR/pFLgS56NLFji8eoZKQAOALU5
Thread-topic: [Xen-devel] [VTD][patch 1/1] vt-d hardware check
User-agent: Microsoft-Entourage/11.3.6.070618
vtd_hw_check() clears vtd_enabled and returns ENODEV, so the caller should
be:

 if (!vtd_enabled)
    return -ENODEV;
 rc = vtd_hw_check();
 if ( rc )
    return rc;

Note that the above code skips acpi_dmar_init() entirely if !vtd_enabled.
This behaviour is different from your patch but I think more sensible?

 -- Keir

On 22/9/07 00:39, "Kay, Allen M" <allen.m.kay@xxxxxxxxx> wrote:

> This patch disables vt-d for old chipset steppings that does not have
> compatible CPU compatible vt-d page table format.
> 
> Signed-off-by: Allen Kay <allen.m.kay@xxxxxxxxx>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>