xen-devel

[Top] [All Lists]

[Xen-devel] [Patch] fix checking strtab length in xc_core.c

from [Akio Takebe]

[Permanent Link][Original]

To:	xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] [Patch] fix checking strtab length in xc_core.c
From:	Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
Date:	Mon, 10 Sep 2007 21:16:23 +0900
Delivery-date:	Mon, 10 Sep 2007 05:17:32 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

Hi,

I don't understard the meaning of the following check in xc_core.c.
Is this correct patch?

Signed-off-by: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>

diff -r 9071521d4864 tools/libxc/xc_core.c
--- a/tools/libxc/xc_core.c     Fri Sep 07 11:39:10 2007 +0100
+++ b/tools/libxc/xc_core.c     Tue Sep 11 06:13:55 2007 +0900
@@ -107,7 +107,7 @@ xc_core_strtab_get(struct xc_core_strtab
     if ( strtab->current + len > strtab->max )
     {
         char *tmp;
-        if ( strtab->max * 2 < strtab->max )
+        if ( strtab->current + len > strtab->max * 2 )
         {
             PERROR("too long string table");
             errno = ENOMEM;

Best Regards,

Akio Takebe

fix_xc_core_strtab_len.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [Patch] fix checking strtab length in xc_core.c, Akio Takebe <= Re: [Xen-devel] [Patch] fix checking strtab length in xc_core.c, Keir Fraser Re: [Xen-devel] [Patch] fix checking strtab length in xc_core.c, Akio Takebe

Previous by Date:	Re: [Xen-devel] Xen 3.1.1 -- initial patchqueue, Keir Fraser
Next by Date:	Re: [Xen-devel] Xen 3.1.1 -- initial patchqueue, Ben Guthro
Previous by Thread:	[XenPPC] Xen 3.1.1 -- initial patchqueue, Keir Fraser
Next by Thread:	Re: [Xen-devel] [Patch] fix checking strtab length in xc_core.c, Keir Fraser
Indexes:	[Date] [Thread] [Top] [All Lists]