Re: [Xen-devel] [PATCH] Fix xm block/network-detach command (take2)

[Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>]

Hi Jim,

Thanks for your review. 

Best regards,
 Kan

Fri, 10 Aug 2007 16:08:23 -0600, Jim Fehlig wrote:

>Masaki Kanno wrote:
>> Hi Jim,
>>
>> Thanks for your tests.
>>
>>   
>>> I tested your patch briefly on c/s 15672.
>>>     
>> <snip>
>>   
>>> The device was unplugged but its config not removed. From xend.log:
>>>
>>> File "/usr/lib64/python2.4/xen/xend/XendDomainInfo.py", line 615, in
>>> destroyDevice
>>> self.info['%s_refs' % deviceClass].remove(dev_uuid)
>>> KeyError: 'tap_refs'
>>>
>>> I think refs for the various disk types all fall under 'vbd_refs'.
>>>     
>>
>> I tested blktap with the same way as your operation.  But I did not 
>> encounter the command error as follows. 
>> But your thinking is right, so I wrote a small patch to remove the 
>> error message.  Could you test the patch again? 
>>   
>
>Looks good with your additional patch. Thanks.
>
><snip>
>>> The behavior is fine (i.e. the disk is still attached and remains in
>>> stored config) but the error message is misleading. xvbd is connected,
>>> its just the front-end won't let go AFAIK.
>>>     
>>
>> I'd like to improve the error message.  Could you give me thinking 
>> time about 2 weeks? 
>>   
>
>Sure. I just noticed it while testing but spent no time investigating.
>
>Regards,
>Jim
>
>
>_______________________________________________
>Xen-devel mailing list
>Xen-devel@xxxxxxxxxxxxxxxxxxx
>http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel