WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Make XEN_DOMCTL_destroydomain hypercall return e

To: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Make XEN_DOMCTL_destroydomain hypercall return error
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Thu, 09 Aug 2007 11:18:05 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 09 Aug 2007 03:15:58 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070809100942.GD23813%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcfabpLy0b9CkkZhEdyKhAAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] Make XEN_DOMCTL_destroydomain hypercall return error
User-agent: Microsoft-Entourage/11.3.3.061214


On 9/8/07 11:09, "Isaku Yamahata" <yamahata@xxxxxxxxxxxxx> wrote:

> Thank you for reviewing.
> test_and_set_bool(d->is_dying) is used to avoid race, isn't it?
> But the updated patch drops it so that it would be racy.

The only caller is serailised on domctl_lock, so the test_and_set_bool() was
not really necessary.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel