WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] fully virtualized vista

To: Ky Srinivasan <ksrinivasan@xxxxxxxxxx>
Subject: Re: [Xen-devel] fully virtualized vista
From: Ben Guthro <bguthro@xxxxxxxxxxxxxxx>
Date: Wed, 08 Aug 2007 15:15:48 -0400
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 08 Aug 2007 12:13:22 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <46B9CCD4.E57C.0030.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <46B9C28E.E57C.0030.0@xxxxxxxxxx> <46BA0E9B.6020305@xxxxxxxxxxxxxxx> <46B9CCD4.E57C.0030.0@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.4 (X11/20070615)
Patch is attached. Hope this helps


Ky Srinivasan wrote:
Thanks Ben. I would be interested in the patch.

K. Y

On Wed, Aug 8, 2007 at  2:42 PM, in message <46BA0E9B.6020305@xxxxxxxxxxxxxxx>,
Ben Guthro <bguthro@xxxxxxxxxxxxxxx> wrote:
There is a CRC bug in the RTL8139 implementation in the QEMU used in 3.1
There have been discussions of this on the QEMU list, as well.

We have a patch for 3.1, but have not ported it forward to unstable yet, since unstable is using a newer version of QEMU.

If there is interest in seeing the 3.1 patch, I'd be happy to post it.



Ky Srinivasan wrote:
I am having networking issues on fully virtualized Vista. Is this a known
issue.
K. Y



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel



diff -r 05858d742ba7 tools/ioemu/hw/rtl8139.c
--- a/tools/ioemu/hw/rtl8139.c  Wed Jul 18 10:46:24 2007 -0400
+++ b/tools/ioemu/hw/rtl8139.c  Wed Jul 18 10:46:30 2007 -0400
@@ -55,7 +55,7 @@
 
 /* RTL8139 provides frame CRC with received packet, this feature seems to be
    ignored by most drivers, disabled by default */
-//#define RTL8139_CALCULATE_RXCRC 1
+#define RTL8139_CALCULATE_RXCRC 1
 
 /* Uncomment to enable on-board timer interrupts */
 //#define RTL8139_ONBOARD_TIMER 1
@@ -1032,7 +1032,7 @@ static void rtl8139_do_receive(void *opa
 
         /* write checksum */
 #if defined (RTL8139_CALCULATE_RXCRC)
-        val = cpu_to_le32(crc32(~0, buf, size));
+        val = cpu_to_le32(crc32(0, buf, size));
 #else
         val = 0;
 #endif
@@ -1138,7 +1138,7 @@ static void rtl8139_do_receive(void *opa
 
         /* write checksum */
 #if defined (RTL8139_CALCULATE_RXCRC)
-        val = cpu_to_le32(crc32(~0, buf, size));
+        val = cpu_to_le32(crc32(0, buf, size));
 #else
         val = 0;
 #endif
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel