WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Will hap_alloc fail?

At 18:19 +0100 on 12 Jul (1184264340), Mats Petersson wrote:
> I would have thought that domain_crash() is the right thing to do - 
> there's nothing "better" that can be done elsewhere, as far as I can 
> understand, and there's really no point in propagating an error 
> unless there's something that can be done about it (or it can be 
> ignored, which isn't the case in this instance), as this only leads 
> to potential misses of the propagated error, making it harder to debug.

You need to do both, unfortunately.  domain_crash() just marks the
domain as crashed; we still need to survive the rest of the code path
for the action we're taking without following a null pointer or similar.

Cheers,

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>, XenSource UK Limited
Registered office c/o EC2Y 5EB, UK; company number 05334508

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel