WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 2/4] [Net] Support accelerated network pluginmodu

To: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2/4] [Net] Support accelerated network pluginmodules
From: Kieran Mansley <kmansley@xxxxxxxxxxxxxx>
Date: Tue, 10 Jul 2007 14:12:52 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 10 Jul 2007 06:10:52 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <63C7C29CECD3E0kanno.masaki@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1183982983.4127.23.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <63C7C29CECD3E0kanno.masaki@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, 2007-07-10 at 11:49 +0900, Masaki Kanno wrote:
> Hi Kieran,
> 
> I have a request and a question. 
> 
> Request:
>  I think that we need to fix the help message of xm create command 
>  for the accel option, so I wrote a patch for it.  I attach the 
>  patch.  Could you comment on the patch?

Looks good to me, thanks for noticing that and providing the patch.
Keir: could you apply this as well?

> Question:
>  I ask you a question without understanding your patch enough. 
>  Why did not you add the accel option to xm network-attach command? 

I probably should have done: it's not a command I've ever used and so I
overlooked it.  I'll make a patch for that asap.

Thanks

Kieran



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>