 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] Re: A wrong assert in get_ioreq()?
| To: | "Keir Fraser" <keir@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] Re: A wrong assert in get_ioreq()? |
| From: | "Paul Samon" <paul.samon@xxxxxxxxx> |
| Date: | Thu, 5 Jul 2007 09:08:44 +0800 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Wed, 04 Jul 2007 18:06:34 -0700 |
| Dkim-signature: | a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=a7gz96hFuWkqGf4XqwBnpeYmuMZ03JcZxu3gqhrD/nkCUQkDVhE1u4x9GfIPyeVLV4t9eSlvb4Sh6/+ViDFoUA8UnxMenQmLEtiQAL1UlIJDeK4mfwahe0uCKbgP9fNae8ktzbA8QWdv6mz4le2MARcqQ9FRfIjI6n6kmewoEgw= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=FxOMTbfjfsqA6SZsvLQ2KViMC/z+VVtLlou9BQvkYYvCucjnSW/smpKmU3hDjyLaFT5vYlIfS+NPuxsWvHziRTGc0cbjgG7UNsnwy8efXUG44C1GGS96N6qgzRAFLDPdPrcypdpE3O5ME9xLhe4FBTxpKlfLnOvBXk+O5LlFa7g= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <C2B15D9F.11DBF%keir@xxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <34cec8c90707040412s4aa16fcdlbdd252e42a05f76e@xxxxxxxxxxxxxx> <C2B15D9F.11DBF%keir@xxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
Yes, the lock is necessary (for hvm_vcpu_initialise()), but my question is: in the ASSERT of get_ioreq(), we shouldn't check if we have got the lock, and we don't have the lock in it (if I'm wrong, please point out where we get the lock), that is, in get_ioreq(), I think spin_is_locked(&d->
arch.hvm_domain.ioreq.lock) always returns false.
-- Paul S.
On 7/4/07, Keir Fraser <keir@xxxxxxxxxxxxx> wrote:
_______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [PATCH] xen: can't support numa yet, Jeremy Fitzhardinge |
|---|---|
| Next by Date: | Re: [Xen-devel] Fix xm block/network-attach command for inactivemanaged domain, Masaki Kanno |
| Previous by Thread: | Re: [Xen-devel] Re: A wrong assert in get_ioreq()?, Keir Fraser |
| Next by Thread: | [Xen-ia64-devel] [Patch] ARCH_HAS_DEV_MEM patch for Xwindow on IA64 machine, Jun Kamada |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
