WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] 'block' script broken: wrong error message

To: "Jacek Konieczny" <jajcus@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] 'block' script broken: wrong error message
From: "Ian Pratt" <Ian.Pratt@xxxxxxxxxxxx>
Date: Wed, 4 Jul 2007 18:32:36 +0100
Delivery-date: Wed, 04 Jul 2007 10:31:03 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070704122700.GB7204@xxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Ace+NsLVYZLKX/hRSPGkfWvsyT244gAKfNhA
Thread-topic: [Xen-devel] 'block' script broken: wrong error message
> The last line effectively discards directory name for comparison ($f
is
> compared to $file later) if readlink of "$f" fails. In my case $f
don't
> even exists, so the directories are ignored and only basename (which
is the
> same for all my virtual machines) is compared.

The current basename comparison is foul, but losetup doesn't exactly
make it easy to do the right thing.

> And another thing: why are path names compared instead of inode
numbers.

If you know how to get the filesystem and inode numbers out of losetup,
great!

The alternative is to have xend explicitly remember what loop devices
its set up and work on the assumption that people aren't doing things
behind its back.

Ian

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>