| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] RE: [Patch] Add NMI Injection and Pending Support inVMX
|
To: |
"Shan, Haitao" <haitao.shan@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|
Subject: |
Re: [Xen-devel] RE: [Patch] Add NMI Injection and Pending Support inVMX |
|
From: |
Keir Fraser <keir@xxxxxxxxxxxxx> |
|
Date: |
Wed, 04 Jul 2007 10:32:20 +0100 |
|
Cc: |
"Li, Xin B" <xin.b.li@xxxxxxxxx>, "Dong, Eddie" <eddie.dong@xxxxxxxxx>, "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>, "Li, Susie" <susie.li@xxxxxxxxx> |
|
Delivery-date: |
Wed, 04 Jul 2007 02:30:57 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<823A93EED437D048963A3697DB0E35DE6E5BE6@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
Thread-index: |
AcezKHO8GVeq3H5BSPWle/Skc4bxjQACFWLQAGC4rxACMsm0wAAG46WYABEyaXAABYzGAAAKNnOU |
|
Thread-topic: |
[Xen-devel] RE: [Patch] Add NMI Injection and Pending Support inVMX |
|
User-agent: |
Microsoft-Entourage/11.3.3.061214 |
On 4/7/07 05:44, "Shan, Haitao" <haitao.shan@xxxxxxxxx> wrote:
> 1> If we do have IDT vectoring occurs, and at the same time, a NMI or irq is
> pending, should we better do a check to enable_intr_window instead of just
> return?
> if ( (idtv_info_field&INTR_INFO_INTR_TYPE_MASK) == INTR_TYPE_NMI )
> __vmwrite(GUEST_INTERRUPTIBILITY_INFO,
> __vmread(GUEST_INTERRUPTIBILITY_INFO) &
> ~VMX_INTR_SHADOW_NMI);
> HVM_DBG_LOG(DBG_LEVEL_1, "idtv_info_field=%x", idtv_info_field);
> return;
That case does include a call to enable_intr_window(), immediately before
the code you quote. Did you miss that?
> -----------------------------The second question is here----------------
> 2> In enable_intr_window, if it is an NMI, then change intr_shadow from
> blocking_by_sti to blocking_by_movss if there is such case. But the
> intr_shadow is not written back to VMCS. Why should we do so?
This is a stupid mistake on my part. I'll fix it.
Thanks,
Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home