|   | 
      | 
  
  
      | 
      | 
  
 
     | 
    | 
  
  
     | 
    | 
  
  
    |   | 
      | 
  
  
    | 
         
xen-devel
[Xen-devel] Re: 2.6.22-rc6-mm1: Xen: WARNING: Absolute relocations	prese
 
| 
To:  | 
"Eric W. Biederman" <ebiederm@xxxxxxxxxxxx> | 
 
| 
Subject:  | 
[Xen-devel] Re: 2.6.22-rc6-mm1: Xen: WARNING: Absolute relocations	present | 
 
| 
From:  | 
Jeremy Fitzhardinge <jeremy@xxxxxxxx> | 
 
| 
Date:  | 
Sun, 01 Jul 2007 09:33:08 -0700 | 
 
| 
Cc:  | 
xen-devel@xxxxxxxxxxxxxxxxxxx, Jeremy Fitzhardinge <jeremy@xxxxxxxxxxxxx>,	linux-kernel@xxxxxxxxxxxxxxx, Andi Kleen <ak@xxxxxxx>,	Adrian Bunk <bunk@xxxxxxxxx>, chrisw@xxxxxxxxxxxx,	Vivek Goyal <vgoyal@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> | 
 
| 
Delivery-date:  | 
Sun, 01 Jul 2007 09:31:10 -0700 | 
 
| 
Envelope-to:  | 
www-data@xxxxxxxxxxxxxxxxxx | 
 
| 
In-reply-to:  | 
<m1hcoorv79.fsf@xxxxxxxxxxxxxxxxxxxxxxxxx> | 
 
| 
List-help:  | 
<mailto:xen-devel-request@lists.xensource.com?subject=help> | 
 
| 
List-id:  | 
Xen developer discussion <xen-devel.lists.xensource.com> | 
 
| 
List-post:  | 
<mailto:xen-devel@lists.xensource.com> | 
 
| 
List-subscribe:  | 
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe> | 
 
| 
List-unsubscribe:  | 
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> | 
 
| 
References:  | 
<20070628034321.38c9f12b.akpm@xxxxxxxxxxxxxxxxxxxx>	<20070628204001.GA6087@xxxxxxxxx>	<46841EC4.7080805@xxxxxxxx>	<m1hcoorv79.fsf@xxxxxxxxxxxxxxxxxxxxxxxxx> | 
 
| 
Sender:  | 
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx | 
 
| 
User-agent:  | 
Thunderbird 2.0.0.4 (X11/20070615) | 
 
 
 
Eric W. Biederman wrote:
 
Jeremy Fitzhardinge <jeremy@xxxxxxxx> writes:
   
Adrian Bunk wrote:
     
<--  snip  -->
...
  RELOCS  arch/i386/boot/compressed/vmlinux.relocs
WARNING: Absolute relocations present
Offset     Info     Type     Sym.Value Sym.Name
c0101f80 020c6501   R_386_32 00000000  xen_irq_disable_direct_reloc
c0101f9a 0221ea01   R_386_32 00000000  xen_save_fl_direct_reloc
...
<--  snip  -->
       
 
Hm.  Those are false alarms.  I guess I could do something to hide them, but
there's nothing inherently wrong with correctly used abs symbols.  Is there
someway to whitelist them?
     
 
Yes.  Just add them to arch/i386/boot/compressed/relocs.c safe_abs_syms.
   
 
OK, how's this?
Subject: xen: suppress abs symbol warnings for unused reloc pointers
The Xen code generates some abs symbols which are OK from a relocation
perspective.
Signed-off-by: Jeremy Fitzhardinge <jeremy@xxxxxxxxxxxxx>
Cc: Adrian Bunk <bunk@xxxxxxxxx>
---
arch/i386/boot/compressed/relocs.c |    2 ++
1 file changed, 2 insertions(+)
===================================================================
--- a/arch/i386/boot/compressed/relocs.c
+++ b/arch/i386/boot/compressed/relocs.c
@@ -31,6 +31,8 @@ static const char* safe_abs_relocs[] = {
                "__kernel_rt_sigreturn",
                "__kernel_sigreturn",
                "SYSENTER_RETURN",
+               "xen_irq_disable_direct_reloc",
+               "xen_save_fl_direct_reloc",
};
static int is_safe_abs_reloc(const char* sym_name)
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
 |   
 
 | 
    | 
  
  
    |   | 
    |