WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Make xendomains ignore lost+found

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] Make xendomains ignore lost+found
From: Mark Williamson <mark.williamson@xxxxxxxxxxxx>
Date: Fri, 29 Jun 2007 16:58:18 +0100
Cc: Keir Fraser <keir@xxxxxxxxxxxxx>, Gawain Lynch <gawain.lynch@xxxxxxxxx>
Delivery-date: Fri, 29 Jun 2007 08:56:22 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <a719f8720706282236x3d0b9ed9m1c5447a1e8ce77c7@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <a719f8720706282236x3d0b9ed9m1c5447a1e8ce77c7@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.6
> As requested by Mark Williamson in BZ #681
>
> Signed-off-by: Gawain Lynch <gawain.lynch@xxxxxxxxx>

Gawain, thanks for identifying this and patching it.

This fixes a breakage on resume when the XENDOMAINS_SAVE directory is a 
separate partition.

At some point it /might/ be nice to have more sophisticated checking of what 
is an suspend image, and what's not.  But this patch shouldn't break 
anything, and should fix a user-visible bug for some people.

Acked-by: Mark Williamson <mark.williamson@xxxxxxxxxxxx>


> --- xendomains.orig   2006-06-17 14:35:48.000000000 +1000
> +++ xendomains        2006-06-17 14:45:29.000000000 +1000
> @@ -207,10 +207,11 @@
>      if [ "$XENDOMAINS_RESTORE" = "true" ] &&
>         contains_something "$XENDOMAINS_SAVE"
>      then
> +     XENDOMAINS_SAVED=`/bin/ls $XENDOMAINS_SAVE/* | grep -v 'lost+found'`
>          mkdir -p $(dirname "$LOCKFILE")
>       touch $LOCKFILE
>       echo -n "Restoring Xen domains:"
> -     for dom in $XENDOMAINS_SAVE/*; do
> +     for dom in $XENDOMAINS_SAVED; do
>           echo -n " ${dom##*/}"
>           xm restore $dom
>           if [ $? -ne 0 ]; then
> @@ -239,6 +240,7 @@
>           if is_running $dom; then
>               echo -n "(skip)"
>           else
> +             echo "(booting)"
>               xm create --quiet --defconfig $dom
>               if [ $? -ne 0 ]; then
>                   rc_failed $?
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



-- 
Dave: Just a question. What use is a unicyle with no seat?  And no pedals!
Mark: To answer a question with a question: What use is a skateboard?
Dave: Skateboards have wheels.
Mark: My wheel has a wheel!

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>