WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] x86: eliminate x86_emulate's private EFLAGS defi

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] x86: eliminate x86_emulate's private EFLAGS definitions
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Tue, 19 Jun 2007 11:21:47 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 19 Jun 2007 03:19:12 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C29D6905.10DF2%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4677C411.76E4.0078.0@xxxxxxxxxx> <C29D6905.10DF2%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> 19.06.07 12:05 >>>
>On 19/6/07 10:54, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
>
>> .. in favor of using one of the two (i.e. already redundant) ones
>> found in the headers.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
>
>Currently x86_emulate is buildable 'out of tree', e.g., in tools/tests. I
>want to keep that ability but it is the case that down the line we'll be
>wanting more flags and structures to be sharable outside x86_emulate.c. I'm
>not sure yet what the right way of achieving that will be.

Yes, I was afraid of something like that (I just didn't know that I might be 
able
to build the thing in tools/tests, I thought this was completely out of tree, 
and
hence adding a local header would be possible).

In that light, perhaps doing a little cleanup on the headers having the desired
definitions, so that they can be included for the tool build, will do. I may 
find
some time to look into this possibility.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>