WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 1/12] Add suspend/resume to devices owned by Xen

To: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 1/12] Add suspend/resume to devices owned by Xen
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 11 Jun 2007 11:08:38 +0100
Delivery-date: Mon, 11 Jun 2007 03:06:42 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <D470B4E54465E3469E2ABBC5AFAC390F013B1DF0@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AceW+19nrz3vWNtATFekqBOc/y2imQVFRs2K
Thread-topic: [Xen-devel] [PATCH 1/12] Add suspend/resume to devices owned by Xen
User-agent: Microsoft-Entourage/11.3.3.061214
On 15/5/07 15:14, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:

> +    now = get_cmos_time();
> +    sleep_diff = now - sleep_start;
> +    wc_sec = now;
> +    jiffies += sleep_diff * HZ;
> +    
> +    stime_platform_stamp += SECONDS(sleep_diff);

Is this correct? I think you should either increment wc_sec by sleep_diff,
*or* increment stime by SECONDS(sleep_diff). If you do both, wall clock will
jump by twice the amount it should have done, won't it (because wc_sec is
wallclock time when stime=0)?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>