WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-ia64-devel] Re: [Xen-devel] [RFC][PATCH] "Controller" pcibacken

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-ia64-devel] Re: [Xen-devel] [RFC][PATCH] "Controller" pcibackend and frontend extensions
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Sun, 10 Jun 2007 14:18:07 -0600
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Sun, 10 Jun 2007 13:16:39 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C2920BE6.8D6B%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: HP OSLO R&D
References: <C2920BE6.8D6B%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Sun, 2007-06-10 at 20:13 +0100, Keir Fraser wrote:
> On 10/6/07 19:24, "Alex Williamson" <alex.williamson@xxxxxx> wrote:
> 
> >    I would like to see this backend become the default backend for ia64,
> > but it probably needs testing on other systems before we can make the
> > switch.  I would appreciate testing and/or review feedback.  To make use
> > of extended I/O port spaces, you'll need the patch I sent to
> > xen-ia64-devel last week to register the I/O port spaces with Xen.

Hi Keir,

   Thanks for looking at the patch.

> It would be nice to have just one backend type, with relevant bits of its
> code made arch-specific. I'm sure x86 doesn't need vpci, passthru *and*
> slot.

  I agree, but I wasn't ready to tackle that problem.

> This is probably fine for now; it doesn't preclude merging or dropping other
> backends down the line. Only thing I spotted is that you make an enormous
> inline function in pcifront.h. That function will have to be moved elsewhere
> into a .c file if it's getting that big.

   Right, I forgot about that.  It is rather unwieldy for a static
inline.  I guess pcifront/pci_op.c is the most appropriate place for it.
I'll tuck it in a #ifdef there unless you have a better suggestion.
Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>