WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [Xen-staging] [xen-unstable] If we find a Linux reposito

To: Alex Williamson <alex.williamson@xxxxxx>
Subject: [Xen-devel] Re: [Xen-staging] [xen-unstable] If we find a Linux repository in $(LINUX_SRC_PATH) then symlink it
From: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Date: Mon, 04 Jun 2007 23:03:38 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 04 Jun 2007 15:01:07 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1180993454.6221.200.camel@bling>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200706041442.l54EgKQp007662@xxxxxxxxxxxxxxxxxxxxxxx> <1180982974.6221.151.camel@bling> <1180993053.5416.6.camel@xxxxxxxxxxxxxxxxxxxxxx> <1180993454.6221.200.camel@bling>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, 2007-06-04 at 15:44 -0600, Alex Williamson wrote:
> On Mon, 2007-06-04 at 22:37 +0100, Ian Campbell wrote:
> > On Mon, 2007-06-04 at 12:49 -0600, Alex Williamson wrote:
> > > On Mon, 2007-06-04 at 15:42 +0100, Xen staging patchbot-unstable wrote:
> > > > # HG changeset patch
> > > > # User Ian Campbell <ian.campbell@xxxxxxxxxxxxx>
> > > > # Date 1180968092 -3600
> > > > # Node ID c09dbe98e4d61d29138e8a2918d9ee8a85e1d6cf
> > > > # Parent  5710c94e65394daadafd7a6780450e01a26bf32d
> > > > If we find a Linux repository in $(LINUX_SRC_PATH) then symlink it
> > > > instead of cloning it. This enables developers to keep a linux tree
> > > > separate to their xen repository and to make changes there which are
> > > > picked up by the Xen build.
> > > 
> > >    I don't like this at all, especially without an environment variable
> > > I can use to disable it.  My standard mode of operation is to have a
> > > directory with repos that exactly mirror upstream.  To work on code or
> > > apply patches, I clone those and work from there.  I don't want the
> > > default to be symlink'ing to my 'pristine' upstream repo copies.
> > > Thanks,
> > 
> > export LINUX_SRC_PATH='' should do what you need, no?
> 
>    Nope, that still gives me a symlink'd linux-2.6.18-xen.hg repo.

Are you sure?

$ ls
COPYING    Config.mk.orig  Makefile  buildconfigs/  config/  extras/      
patches/  unmodified_drivers/
Config.mk  Config.mk~      README    commitmsg~     docs/    install.sh*  
tools/    xen/
$ make linux-2.6-xen0-prep
[...snip...]
select-repository: Searching `.:..' for linux-2.6.18-xen.hg
select-repository: Ignoring `.'
select-repository: Found ../linux-2.6.18-xen.hg
Linking ../linux-2.6.18-xen.hg to linux-2.6.18-xen.hg.
$ ls -l
[...snip...]
lrwxrwxrwx   1 ianc xendev    22 Jun  4 22:55 linux-2.6.18-xen.hg -> 
../linux-2.6.18-xen.hg/

versus (in the same directory)

$ make distclean
$ ls
COPYING    Config.mk.orig  Makefile  buildconfigs/  config/  extras/      
patches/  unmodified_drivers/
Config.mk  Config.mk~      README    commitmsg~     docs/    install.sh*  
tools/    xen/
$ LINUX_SRC_PATH='' make linux-2.6-xen0-prep
select-repository: Found http://hg.uk.xensource.com/linux-2.6.18-xen.hg
Cloning http://hg.uk.xensource.com/linux-2.6.18-xen.hg to linux-2.6.18-xen.hg.
$ ls -l 
[...snip...]
drwxr-xr-x   3 ianc xendev    72 Jun  4 22:57 linux-2.6.18-xen.hg/

I think you are saying that you have a directory 'working' which is
parented off a pristine '../xen-unstable.hg'. Therefore it should
calculate the parent Linux repository as being '../linux-2.6.18-xen.hg'
and clone that, since it won't find it via LINUX_SRC_PATH which is ''.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>