WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] [xm] Fix vncdisplay for hvm guests

To: Jim Fehlig <jfehlig@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] [xm] Fix vncdisplay for hvm guests
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Thu, 24 May 2007 15:31:44 +0100
Delivery-date: Thu, 24 May 2007 07:30:21 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <464A3ED1.1010904@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AceeEEBfft4hqQoDEdyL+wAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] [xm] Fix vncdisplay for hvm guests
User-agent: Microsoft-Entourage/11.3.3.061214


On 16/5/07 00:14, "Jim Fehlig" <jfehlig@xxxxxxxxxx> wrote:

> results in '-vncunused' being passed to qemu-dm.  There are several
> approaches
> for a fix - this patch defaults vncdisplay to None in xm options.  It
> currently defaults to 1 and is always included in the image config
> created by configure_hvm() in tools/python/xen/xm/create.py.  In xend
> (tools/python/xen/xend/image.py - parseDeviceModelArgs), vncunused takes
> precedence over vncdisplay.

Looks like it changes vncunused default rather than vncdisplay. Wouldn't the
preferred default be to keep vncunused=1?

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>