xen-devel

[Top] [All Lists]

[Xen-devel] WRITE_MSR

from [Dong, Eddie]

[Permanent Link][Original]

To:	"xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] WRITE_MSR
From:	"Dong, Eddie" <eddie.dong@xxxxxxxxx>
Date:	Thu, 10 May 2007 23:11:44 +0800
Delivery-date:	Thu, 10 May 2007 08:10:19 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<6bc632150705090216i413b7740saf49a56e448e9583@xxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AceSGrxqECW6c94qSz2zmSSLBogIhQA+oO0g
Thread-topic:	WRITE_MSR

Not sure why we do test_bit and then set_bit rather than set_bit directly. Any comments?

diff -r 3ef0510e44d0 xen/arch/x86/hvm/vmx/vmx.c
--- a/xen/arch/x86/hvm/vmx/vmx.c Tue May 08 10:21:23 2007 +0100
+++ b/xen/arch/x86/hvm/vmx/vmx.c Thu May 10 23:09:19 2007 +0800
@@ -103,8 +103,7 @@ static void vmx_save_host_msrs(void)

#define WRITE_MSR(address)                                                  \
         guest_msr_state->msrs[VMX_INDEX_MSR_ ## address] = msr_content;     \
-        if ( !test_bit(VMX_INDEX_MSR_ ## address, &guest_msr_state->flags) )\
-            set_bit(VMX_INDEX_MSR_ ## address, &guest_msr_state->flags);    \
+        set_bit(VMX_INDEX_MSR_ ## address, &guest_msr_state->flags);    \
         wrmsrl(MSR_ ## address, msr_content);                               \
         set_bit(VMX_INDEX_MSR_ ## address, &host_msr_state->flags);         \
         break

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] Please ignore the mail, pradeep singh rautela [Xen-devel] WRITE_MSR, Dong, Eddie <=

Previous by Date:	RE: [Xen-devel] fair scheduling, rahul gundecha
Next by Date:	[Xen-devel] running {MS/free}-DOS under XEN, Tomas Kovacik
Previous by Thread:	[Xen-devel] Please ignore the mail, pradeep singh rautela
Next by Thread:	[Xen-devel] [0/2] Remove netloop by lazy copying in netback, Herbert Xu
Indexes:	[Date] [Thread] [Top] [All Lists]