xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] Fix spurious store changes on rename/migrate

from [john . levon]

[Permanent Link][Original]

To:	xen-devel@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-devel] [PATCH] Fix spurious store changes on rename/migrate
From:	john.levon@xxxxxxx
Date:	Mon, 30 Apr 2007 15:30:25 -0700
Delivery-date:	Mon, 30 Apr 2007 15:28:20 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

# HG changeset patch
# User john.levon@xxxxxxx
# Date 1177972216 25200
# Node ID cdda87d292fe252e18a37ca9d7c385e9e7fed1cd
# Parent  1b4f1d6508e88ba329620cb3c189d16e8f89b7fa
Fix spurious store changes on rename/migrate

_storeChanged() was incorrectly comparing a string to an sxpr, thus always
firing and causing unnecessary watches to be fired in the domU.

Signed-off-by: John Levon <john.levon@xxxxxxx>

diff --git a/tools/python/xen/xend/XendDomainInfo.py 
b/tools/python/xen/xend/XendDomainInfo.py
--- a/tools/python/xen/xend/XendDomainInfo.py
+++ b/tools/python/xen/xend/XendDomainInfo.py
@@ -885,7 +885,7 @@ class XendDomainInfo:
 
         # Check whether image definition has been updated
         image_sxp = self._readVm('image')
-        if image_sxp and image_sxp != self.info.image_sxpr():
+        if image_sxp and image_sxp != sxp.to_string(self.info.image_sxpr()):
             self.info.update_with_image_sxp(sxp.from_string(image_sxp))
             changed = True
 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] Fix spurious store changes on rename/migrate, john . levon <=

Previous by Date:	Re: [Xen-devel] 3.0.5-rc3: Creating HVM guest fails with: Cannot allocate memory, Keir Fraser
Next by Date:	[Xen-devel] [PATCH] attempt to reset logdirty if enable fails, Brendan Cully
Previous by Thread:	[Xen-devel] vesafb, ron minnich
Next by Thread:	[Xen-devel] [PATCH] attempt to reset logdirty if enable fails, Brendan Cully
Indexes:	[Date] [Thread] [Top] [All Lists]