WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] incompatible prototypes

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] incompatible prototypes
From: PUCCETTI Armand <armand.puccetti@xxxxxx>
Date: Fri, 27 Apr 2007 17:51:24 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 27 Apr 2007 08:50:26 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C257740B.E070%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C257740B.E070%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 1.5.0.10 (X11/20070306)
Keir Fraser a écrit :

On 27/4/07 09:23, "PUCCETTI Armand" <armand.puccetti@xxxxxx> wrote:

Also, it seems that in the declaration part (file vmx.c:1966) of the
following fct, some
extern are missing, and that the functions smp_event_check_interrupt and
smp_call_function_interrupt
are also incompatible with their body (in file smp.c:326 and smp.c:332)

Extern is optional on function prototypes. Asmlinkage defines away to
nothing. So there's a lack of consistency, but nothing incorrect.

 -- Keir



You're quite right on the first point. However the incompatible prototypes
might lead to errors if some of these functions are called.

Armand


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>