WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] RE: [Xen-staging] [xen-unstable] hvm rombios: Fix int15

To: "Petersson, Mats" <Mats.Petersson@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] RE: [Xen-staging] [xen-unstable] hvm rombios: Fix int15, func 0x86 (udelay).
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Tue, 24 Apr 2007 13:46:44 +0100
Delivery-date: Tue, 24 Apr 2007 05:45:33 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <907625E08839C4409CE5768403633E0B018E1C51@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AceGYgzVtHEimbjiRzGmk6Ww99B5fAAACvUwAAMZDnU=
Thread-topic: [Xen-devel] RE: [Xen-staging] [xen-unstable] hvm rombios: Fix int15, func 0x86 (udelay).
User-agent: Microsoft-Entourage/11.3.3.061214


On 24/4/07 12:19, "Petersson, Mats" <Mats.Petersson@xxxxxxx> wrote:

> Minor nit: You don't need SEG_SS if you're using bp, as bp defaults to
> SS segment. 
>>        shl  eax, #16
>>        SEG SS
>> -        mov  ax, _int15_function.DX [bx]
>> +        mov  ax, .int15_function32.DX [bp]
> As above.

Oh yes, I missed that simplification.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>