WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] 3.0.4: Soft lockup in netfront in SMP build

To: "Graham, Simon" <Simon.Graham@xxxxxxxxxxx>
Subject: Re: [Xen-devel] 3.0.4: Soft lockup in netfront in SMP build
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Sat, 21 Apr 2007 15:14:16 -0700
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Sat, 21 Apr 2007 15:12:46 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <342BAC0A5467384983B586A6B0B376710548B5AD@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <342BAC0A5467384983B586A6B0B376710548B5AD@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 1.5.0.10 (X11/20070302)
Graham, Simon wrote:
> Just run into a (real) soft lockup running 3.0.4 - stack is at the end of 
> this, but basically:
>
> . network_open acquires the rx spin lock with spin_lock() and then checks for
>   work on the queue and calls (I think) netif_rx_schedule with the lock still 
> held which
>   can call into the hypervisor.
> . An interrupt is delivered to the bottom half of netfront which ends up 
> calling netif_poll
>   which blocks attempting to acquire the rx spin lock.
>
> Oops! 
>
> I see from the unstable tree that this code was recently modified to use 
> spin_lock_bh() instead of spin_lock() as part of a mega-merge of IA64 code - 
> clearly we cant merge this changeset into 3.0.4.
>
> I haven't looked too closely at all of the code yet, but I'm wondering if a 
> judicious change of spin_lock to spin_lock_bh in netfront would be the best 
> approach?
>   

I found a few locking problems when I ran netfront with lockdep
enabled.  Fixes were committed to xen-unstable in 14844:abea8d171503 and
14851:22460cfaca71.  I was wondering if there had been any real cases of
these deadlocking.

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>