WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH][HVM] fix VNIF restore failure on HVM guest with

To: "Zhai, Edwin" <edwin.zhai@xxxxxxxxx>, Ian Pratt <Ian.Pratt@xxxxxxxxxxxx>, Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH][HVM] fix VNIF restore failure on HVM guest with heavy workload
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Tue, 10 Apr 2007 20:16:04 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 10 Apr 2007 12:15:02 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070410164738.GA24587@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acd7pK6/7V0hAueXEduEpQAX8io7RQ==
Thread-topic: [PATCH][HVM] fix VNIF restore failure on HVM guest with heavy workload
User-agent: Microsoft-Entourage/11.2.5.060620
On 10/4/07 17:47, "Zhai, Edwin" <edwin.zhai@xxxxxxxxx> wrote:

> [PATCH][HVM] fix VNIF restore failure on HVM guest with heavy workload
> 
> Signed-off-by: Zhai Edwin <edwin.zhai@xxxxxxxxx>
> 
> VNIF has many intrs when save/restore with net workload, so need keep handler
> from intrs

What happens if an interrupt is being processed during save/restore? It
would be nice to know what the underlying bug is!

That said, it may well make sense to somehow disable interrupt handling
across save/restore. Unfortunately your patch is insufficient since we could
handle event-channel interrupts on any VCPU (the irq's affinity can be
changed outside our control if it is routed through the virtual IOAPIC, and
if e.g. the userspace irqbalance daemon is running).

I wanted to use stop_machine_run() but unfortunately it isn't exported to
modules. :-( irq_disable() may do the right thing for us though.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel