This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: lock issue for vpic_irq_negative_edge

To: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: lock issue for vpic_irq_negative_edge
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Thu, 29 Mar 2007 08:34:00 +0100
Delivery-date: Thu, 29 Mar 2007 00:31:54 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <D470B4E54465E3469E2ABBC5AFAC390F9E1382@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acdxq2rwPOuYrZ93SlCRhY9uMvANXwAKTL/T
Thread-topic: lock issue for vpic_irq_negative_edge
User-agent: Microsoft-Entourage/
On 29/3/07 03:39, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:

> Hi, Keir,
> vPIC has a private lock, but there's no acquisition in the
> injection 
> path. This should be a potential issue for change on IRR. Then the
> assertion (ASSERT(vpic_is_locked(vpic)) is likely to be failed within
> vpic_irq_negative_edge if debug option is enabled. Is anything
> missing here?

No, there actually isn't a private vPIC lock any more. If you look at the
top of the vpic.c file you'll see that the 'vpic lock' is actually an alias
for the generic irq_lock. This is always acquired by the caller of

 -- Keir

> Thanks,
> Kevin

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>