This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] making changes to agp code?

To: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Subject: RE: [Xen-devel] making changes to agp code?
From: "Langsdorf, Mark" <mark.langsdorf@xxxxxxx>
Date: Wed, 28 Mar 2007 17:37:49 -0500
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 28 Mar 2007 15:36:54 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <460AAC21.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1449F58C868D8D4E9C72945771150BDFD9679F@xxxxxxxxxxxxxxxxx> <460AAC21.76E4.0078.0@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcdxUYN0J411nXaaScy+OBv05hhbTwAN/o5Q
Thread-topic: [Xen-devel] making changes to agp code?
> >> On a second look I believe the implementation is broken even 
> >> on native, as long as !CONFIG_FLATMEM, since there's an
> >> assumption that an invalid PFN cannot be followed by a valid
> >> one. For that reason, I think the code needs to be changed to
> >> call e820_any_mapped() (just like aperture.c does). I have a
> >> tentative patch to do that, but don't have a working box with
> >> an 8151.
> >
> >I do.  You can send it to me for testing.
> Attached - depending on what tree you want to apply it on you
> may have to tweak it a little.

I applied it to xen-unstable with some tweaking (my version
doesn't seem to have an i386 e820-xen.c ??) and to 2.6.20.

System booted correctly and ran fine.

Acked-by: Mark Langsdorf <mark.langsdorf@xxxxxxx>

-Mark Langsdorf
Operating Systems Research Center
AMD, Inc.

Xen-devel mailing list