 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] remove redundant rcu_read_unlock
| To: | <ncmike@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] remove redundant rcu_read_unlock |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Wed, 28 Mar 2007 20:22:37 +0100 |
| Delivery-date: | Wed, 28 Mar 2007 12:20:35 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20070328190626.GA7940@xxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcdxbnGfsHIGOt1hEduMlAAWy6hiGQ== |
| Thread-topic: | [Xen-devel] [PATCH] remove redundant rcu_read_unlock |
| User-agent: | Microsoft-Entourage/11.3.3.061214 |
On 28/3/07 20:06, "Mike D. Day" <ncmike@xxxxxxxxxx> wrote: > In the function rcu_lock_domain_by_id there is a call to > rcu_read_unlock just prior to returning. However, the intent is that > the rcu reader retain the read lock after the call has returned. This > can be verified by auditing the callers of this routine, which each > explicitly call rcu_unlock_domain, which in turn calls > rcu_read_unlock. > > -- > Remove redundant call to rcu_read_unlock. It's not redundant -- that's the error path (returning NULL). Callers do not call the unlock function in this case. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [PATCH] remove redundant rcu_read_unlock, Mike D. Day |
|---|---|
| Next by Date: | [Xen-devel] The context switch overhead comparison between vmexit/vmentry and hypercall., Liang Yang |
| Previous by Thread: | [Xen-devel] [PATCH] remove redundant rcu_read_unlock, Mike D. Day |
| Next by Thread: | [Xen-devel] Is unmodified_drivers broken?, Subrahmanian, Raj |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
