 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH][HAP][2/2] fix CR4 initialization when hap is on
| To: | "Huang2, Wei" <Wei.Huang2@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>, Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH][HAP][2/2] fix CR4 initialization when hap is on |
| From: | Keir Fraser <keir@xxxxxxxxxxxxx> |
| Date: | Tue, 27 Mar 2007 17:13:43 +0100 |
| Delivery-date: | Tue, 27 Mar 2007 09:12:47 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <7D748C767B7FA541A8AC5504A4C89A23015685DC@xxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcdsnQGbE/OlOb8/T362nmc3AA3U0QD7eIHZ |
| Thread-topic: | [Xen-devel] [PATCH][HAP][2/2] fix CR4 initialization when hap is on |
| User-agent: | Microsoft-Entourage/11.2.5.060620 |
|
This seems an odd change. The earlier setting of CR4 in construct_vmcb() already masks out paging-related bits. So why would the remaining bits’ behaviour differ between hap and shadow paging modes? It would seem to me that either CR4 should be zero at start-of-day in all cases (seems quite likely to me as that’s what happens in a native system), or the existing code should be okay in both cases. -- Keir On 22/3/07 16:13, "Huang2, Wei" <Wei.Huang2@xxxxxxx> wrote: This patch initializes VMCB CR4 and shadow CR4 with 0 when VMCB is being constructed under nested paging mode. It complies with recent reset_to_realmode change in hvmloader. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] Dynamic Loading of Domain Memory Image, Joe Laws |
|---|---|
| Next by Date: | Re: [Xen-devel] Backend device not found error, Adit Ranadive |
| Previous by Thread: | [Xen-devel] [PATCH][HAP][2/2] fix CR4 initialization when hap is on, Huang2, Wei |
| Next by Thread: | RE: [Xen-devel] [PATCH][HAP][2/2] fix CR4 initialization when hap is on, Huang2, Wei |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
