WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] rcu readers - remove dummy lock object

To: <ncmike@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] rcu readers - remove dummy lock object
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 26 Mar 2007 19:20:39 +0100
Delivery-date: Mon, 26 Mar 2007 11:18:53 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070325195853.GA6407@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acdv03Sys42bntvGEdu/NgAWy6hiGQ==
Thread-topic: [Xen-devel] [PATCH] rcu readers - remove dummy lock object
User-agent: Microsoft-Entourage/11.3.3.061214
On 25/3/07 20:58, "Mike D. Day" <ncmike@xxxxxxxxxx> wrote:

> rcu_read_lock and rcu_read_unlock in Xen are empty macros used to
> document the use of rcu techniques. The Xen definition for rcu readers
> uses a dummy lock object. The upstream linux code has since redefined
> rcu reader lock routines to omit the dummy lock object. This makes rcu
> read locking appear similar to memory barriers and other instructions
> that do not take an operand.

I added the dummy 'lock' object explicitly, as it makes it clearer what
object is protected by the critical section. The fact that the operations
and the dummy lock typedef both have rcu in the name should avoid confusion
with spinlocks.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>