This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [Patch][RFC] correct retry limit of balloon

To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [Patch][RFC] correct retry limit of balloon
From: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
Date: Sun, 25 Mar 2007 09:50:04 +0900
Delivery-date: Sat, 24 Mar 2007 17:49:52 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi, all

Balloon wait free memory become enough need memory.
The waiting time is retries * rlimit. When retries =0,
rlimit add ((need_mem - free_mem)/1024/1024) * RETRY_LIMIT_INCR once for all.
But log.debug message show retries. (Why? retries is always 0.)

So I think the following patch is what you really want to do.
What do you think?

Signed-off-by: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>

diff -r 2d918219f234 tools/python/xen/xend/balloon.py
--- a/tools/python/xen/xend/balloon.py  Thu Mar 22 18:41:15 2007 +0000
+++ b/tools/python/xen/xend/balloon.py  Sun Mar 25 09:38:02 2007 +0900
@@ -127,7 +127,7 @@ def free(need_mem):
                           free_mem, need_mem)
-            if retries == 0:
+            if retries != 0:
                 rlimit += ((need_mem - free_mem)/1024/1024) * RETRY_LIMIT_INCR
                 log.debug("Balloon: %d KiB free; %d to scrub; need %d; 
retries: %d.",
                           free_mem, scrub_mem, need_mem, rlimit)

Best Regards,

Akio Takebe

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>