This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] HVM save/restore issue

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] HVM save/restore issue
From: Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>
Date: Tue, 20 Mar 2007 10:04:52 +0000
Cc: Tim <Tim.Deegan@xxxxxxxxxxxxx>, Ewan Mellor <ewan@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, "Zhai, Edwin" <edwin.zhai@xxxxxxxxx>
Delivery-date: Tue, 20 Mar 2007 03:07:29 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C2254BEA.4A20%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070320081236.GJ21485@xxxxxxxxxxxxxxxxxxxxxx> <C2254BEA.4A20%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.13 (2006-08-11)
At 08:29 +0000 on 20 Mar (1174379370), Keir Fraser wrote:
> On 20/3/07 08:12, "Zhai, Edwin" <edwin.zhai@xxxxxxxxx> wrote:
> > latest HVM save/restore break again:(
> > 
> > i use the memsize(the number in the xmexample.hvm) deduced from
> > 'memory_static_min' to calculate some HVM PFNs when restore.
> Out of interest: why would you do this? I glanced upon the code you are
> referring to in xc_hvm_restore.c yesterday, and it struck me as particularly
> gross. All three PFNs (ioreq, bufioreq, xenstore) could be saved in the
> store after building the domain and then saved/restored as part of the
> Python-saved data. The situation is easier than for a PV guest because PFNs
> do not change across save/restore.

It's probably safe just to remove the special handling for those PFNs --
I expanded it a bit when I was fixing up the case where ioreqs were in
flight during the save, but that shouldn't be necessary (and they will
have been set to the same magic values by the hvm domain builder on



Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>, XenSource UK Limited
Registered office c/o EC2Y 5EB, UK; company number 05334508

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>