[Xen-devel] [PATCH] the address of 'symbols_addresses' will always evaluate as 'true'

["S.Çağlar Onur" <caglar@xxxxxxxxxxxxx>]

Hi;

With gcc-4.2.x xen fails to compile like following;

gcc -O2 -fomit-frame-pointer -m32 -march=i686 -DNDEBUG -std=gnu99 -Wall 
-Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement -nostdinc 
-fno-builtin -fno-common -fno-strict-aliasing -iwithprefix 
include -Werror -Wno-pointer-arith -pipe 
-I/home/caglar/svn/xen-3.0.4-testing.hg/xen/include 
-I/home/caglar/svn/xen-3.0.4-testing.hg/xen/include/asm-x86/mach-generic 
-I/home/caglar/svn/xen-3.0.4-testing.hg/xen/include/asm-x86/mach-default 
-msoft-float -fno-stack-protector -g -D__XEN__ -c 
symbols.c -o symbols.o
cc1: warnings being treated as errors
symbols.c: In function 'symbols_lookup':
symbols.c:97: warning: the address of 'symbols_addresses' will always evaluate 
as 'true'

*** 1 errors, 0 warnings
make[3]: *** [symbols.o] Error 1
make[3]: Leaving directory `/home/caglar/svn/xen-3.0.4-testing.hg/xen/common'
make[2]: *** [/home/caglar/svn/xen-3.0.4-testing.hg/xen/common/built_in.o] 
Error 2
make[2]: Leaving directory 
`/home/caglar/svn/xen-3.0.4-testing.hg/xen/arch/x86'
make[1]: *** [/home/caglar/svn/xen-3.0.4-testing.hg/xen/xen] Error 2
make[1]: Leaving directory `/home/caglar/svn/xen-3.0.4-testing.hg/xen'
make: *** [build] Error 2

Following patch (against xen-3.0.4-testing) replaces that part

Signed-off-by: S.Çağlar Onur <caglar@xxxxxxxxxxxxx>

diff -r 3341afbb1953 xen/common/symbols.c
--- a/xen/common/symbols.c      Thu Feb 15 11:34:58 2007 +0000
+++ b/xen/common/symbols.c      Mon Mar 19 01:36:59 2007 +0200
@@ -94,7 +94,7 @@ const char *symbols_lookup(unsigned long
     unsigned long symbol_end = 0;
 
     /* This kernel should never had been booted. */
-    BUG_ON(!symbols_addresses);
+    BUG_ON(symbols_num_syms == 0);
 
     namebuf[KSYM_NAME_LEN] = 0;
     namebuf[0] = 0;

Cheers
-- 
S.Çağlar Onur <caglar@xxxxxxxxxxxxx>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!

pgpHoqrbAGLKA.pgp
Description: PGP signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel