This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] the address of 'symbols_addresses' will always evalu

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] the address of 'symbols_addresses' will always evaluate as 'true'
From: "S.Çağlar Onur" <caglar@xxxxxxxxxxxxx>
Date: Mon, 19 Mar 2007 02:13:11 +0200
Delivery-date: Sun, 18 Mar 2007 17:12:34 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: TÜBİTAK / UEKAE
Reply-to: caglar@xxxxxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.6

With gcc-4.2.x xen fails to compile like following;

gcc -O2 -fomit-frame-pointer -m32 -march=i686 -DNDEBUG -std=gnu99 -Wall 
-Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement -nostdinc 
-fno-builtin -fno-common -fno-strict-aliasing -iwithprefix 
include -Werror -Wno-pointer-arith -pipe 
-msoft-float -fno-stack-protector -g -D__XEN__ -c 
symbols.c -o symbols.o
cc1: warnings being treated as errors
symbols.c: In function 'symbols_lookup':
symbols.c:97: warning: the address of 'symbols_addresses' will always evaluate 
as 'true'

*** 1 errors, 0 warnings
make[3]: *** [symbols.o] Error 1
make[3]: Leaving directory `/home/caglar/svn/xen-3.0.4-testing.hg/xen/common'
make[2]: *** [/home/caglar/svn/xen-3.0.4-testing.hg/xen/common/built_in.o] 
Error 2
make[2]: Leaving directory 
make[1]: *** [/home/caglar/svn/xen-3.0.4-testing.hg/xen/xen] Error 2
make[1]: Leaving directory `/home/caglar/svn/xen-3.0.4-testing.hg/xen'
make: *** [build] Error 2

Following patch (against xen-3.0.4-testing) replaces that part

Signed-off-by: S.Çağlar Onur <caglar@xxxxxxxxxxxxx>

diff -r 3341afbb1953 xen/common/symbols.c
--- a/xen/common/symbols.c      Thu Feb 15 11:34:58 2007 +0000
+++ b/xen/common/symbols.c      Mon Mar 19 01:36:59 2007 +0200
@@ -94,7 +94,7 @@ const char *symbols_lookup(unsigned long
     unsigned long symbol_end = 0;
     /* This kernel should never had been booted. */
-    BUG_ON(!symbols_addresses);
+    BUG_ON(symbols_num_syms == 0);
     namebuf[KSYM_NAME_LEN] = 0;
     namebuf[0] = 0;

S.Çağlar Onur <caglar@xxxxxxxxxxxxx>

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!

Attachment: pgpHoqrbAGLKA.pgp
Description: PGP signature

Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] the address of 'symbols_addresses' will always evaluate as 'true', S.Çağlar Onur <=