This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: HVM save/restore issue

To: "Zhai, Edwin" <edwin.zhai@xxxxxxxxx>
Subject: [Xen-devel] Re: HVM save/restore issue
From: Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>
Date: Thu, 15 Mar 2007 10:02:44 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 15 Mar 2007 03:04:24 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070315074842.GA21485@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070315074842.GA21485@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.13 (2006-08-11)
At 15:48 +0800 on 15 Mar (1173973722), Zhai, Edwin wrote:
> all,
> there are 2 issues of HVM save/restore:
> 1. restore would cause a type dismatch exception, which can be fixed by 
> attached 
> patch.

I can't reproduce this exception. 

>      if is_hvm:
>          hvm  = dominfo.info['memory_static_min']
> -        apic = dominfo.info['platform'].get('apic', 0)
> -        pae  = dominfo.info['platform'].get('pae',  0)
> +        apic = int(dominfo.info['platform'].get('apic', 0))
> +        pae  = int(dominfo.info['platform'].get('pae',  0))

AFAICS, 'apic' and 'pae' are mapped through str() when they're used, so I
don't see that it helps to cast them to integers now.
Is there a reason you don't pass 'hvm' through int() as well?



Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>, XenSource UK Limited
Registered office c/o EC2Y 5EB, UK; company number 05334508

Xen-devel mailing list