This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] 3.0.4 (and earlier): skbuff_ctor() use of xen_create_con

To: Jan Beulich <jbeulich@xxxxxxxxxx>, David Edmondson <dme@xxxxxxx>
Subject: Re: [Xen-devel] 3.0.4 (and earlier): skbuff_ctor() use of xen_create_contiguous_region()
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Fri, 09 Mar 2007 14:08:45 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 09 Mar 2007 06:08:02 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <45F164F7.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcdiVHMHsYDWVM5HEduPNwAX8io7RQ==
Thread-topic: [Xen-devel] 3.0.4 (and earlier): skbuff_ctor() use of xen_create_contiguous_region()
User-agent: Microsoft-Entourage/
On 9/3/07 12:45, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> I understand that, but what I wanted clarification on is whether this is
> only for performance, not for correctness (and performance would still
> suffer if the allocation turns out to be beyond the physical reach of the
> particular NIC).

Yes, and yes (specifically primarily the jumbo-frame receive case, as
described in my previous email). Thus you may want to consider keeping the
patch in your own kernel.

 -- Keir

Xen-devel mailing list