Re: [Xen-devel] [PATCH] dump-core: store .xen_p2m or .xen_pfn se

To:	Isaku Yamahata <yamahata@xxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] dump-core: store .xen_p2m or .xen_pfn section in pfn ascending order.
From:	Keir Fraser <keir@xxxxxxxxxxxxx>
Date:	Fri, 09 Mar 2007 11:35:54 +0000
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx, anderson@xxxxxxxxxx
Delivery-date:	Fri, 09 Mar 2007 03:35:13 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<20070309113129.GK999%yamahata@xxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcdiPxiwVyH50s4yEduPNwAX8io7RQ==
Thread-topic:	[Xen-devel] [PATCH] dump-core: store .xen_p2m or .xen_pfn section in pfn ascending order.
User-agent:	Microsoft-Entourage/11.2.5.060620

On 9/3/07 11:31, "Isaku Yamahata" <yamahata@xxxxxxxxxxxxx> wrote:

>> But shouldn't it be
>> easy to generate the memory-area list in order in the first place?
> 
> Dave, do you have any opinion?

I'm just thinking, it looks like a static list to me. Maybe you don't want
to make assumptions based on the #define'd constants though? Either way, I
think requiring xc_core_arch_memory_map_get() to return the required
ordering makes sense.

 -- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH] dump-core: store .xen_p2m or .xen_pfn section in