This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] page ownership

To: Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] page ownership
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Thu, 08 Mar 2007 10:23:15 +0000
Delivery-date: Thu, 08 Mar 2007 02:22:30 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <45EFEF3B.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acdha8gbBudSdM1fEduQtwAX8io7RQ==
Thread-topic: [Xen-devel] page ownership
User-agent: Microsoft-Entourage/
On 8/3/07 10:10, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> Is there a particular reason why page_set_owner(pg, NULL) is
> - not used in free_domheap_pages()?

It's done in __alloc_domheap_pages() instead. Arguably moving it would be

> - only used on pages 1 ... ((1 << order) - 1) in __alloc_domheap_pages()?

Page 0 is done outside the loop, and writes directly to _domain for no
particularly good reason. I guess I implemented the first iteration outside
the loop to special-case initialisation of the tlbflush cpumask. Which
probably isn't a very worthwhile optimisation, to be honest.

I'll do a little cleanup here. It would certainly be sane to not have random
domain pointers hanging around in freed pages.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>