xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] netfront: adjust clearing of extras space

from [Jan Beulich]

[Permanent Link][Original]

To:	<xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] [PATCH] netfront: adjust clearing of extras space
From:	"Jan Beulich" <jbeulich@xxxxxxxxxx>
Date:	Wed, 07 Mar 2007 14:56:18 +0000
Delivery-date:	Wed, 07 Mar 2007 06:56:05 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

This fixes a latent bug if there will ever be a second kind of extra
defined.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

Index: head-2007-02-27/drivers/xen/netfront/netfront.c
===================================================================
--- head-2007-02-27.orig/drivers/xen/netfront/netfront.c        2007-02-27 
16:31:12.000000000 +0100
+++ head-2007-02-27/drivers/xen/netfront/netfront.c     2007-03-07 
13:14:12.000000000 +0100
@@ -1317,7 +1317,7 @@ static int netif_poll(struct net_device 
        work_done = 0;
        while ((i != rp) && (work_done < budget)) {
                memcpy(rx, RING_GET_RESPONSE(&np->rx, i), sizeof(*rx));
-               memset(extras, 0, sizeof(extras));
+               memset(extras, 0, sizeof(rinfo.extras));
 
                err = xennet_get_responses(np, &rinfo, rp, &tmpq,
                                           &pages_flipped);



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] netfront: adjust clearing of extras space, Jan Beulich <= Re: [Xen-devel] [PATCH] netfront: adjust clearing of extras space, Herbert Xu

Previous by Date:	[Xen-devel] [PATCH][XEND]Reprt error for a existing file, Kazuki Mizushima
Next by Date:	Re: [Xen-devel] How to disable xen debugger?, Lily Huang
Previous by Thread:	[Xen-devel] [PATCH][XEND]Reprt error for a existing file, Kazuki Mizushima
Next by Thread:	Re: [Xen-devel] [PATCH] netfront: adjust clearing of extras space, Herbert Xu
Indexes:	[Date] [Thread] [Top] [All Lists]