This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] linux/x86-64: allow kernel init memory to be fre

To: Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] linux/x86-64: allow kernel init memory to be freed
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Fri, 02 Mar 2007 15:23:40 +0000
Delivery-date: Fri, 02 Mar 2007 07:22:58 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <45E812E4.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acdc3sFd/75UmsjREduwRgAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] linux/x86-64: allow kernel init memory to be freed
User-agent: Microsoft-Entourage/
On 2/3/07 11:04, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> +  if (addr >= __START_KERNEL_map) {
> +   /* make_readonly() reports all kernel addresses. */
> +   __make_page_writable(__va(__pa(addr)));
> +   __make_page_readonly((void *)addr);
> +  }

I'm confused by this:
 1. Why does the write-protection need to be changed unconditionally, or
even at all? Is there anything write-protected in the init sections?
 2. Is it safe to keep init mappings above START_KERNEL_map at all, even
read-only? I'd have thought we'd be in trouble if the balloon driver manages
to allocate those pages and tries to free them to Xen. Perhaps they should
be blown away entirely?

 -- Keir

Xen-devel mailing list