This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH][retry 2] Make x86_64 swiotlb code to support dma

To: "Mark Langsdorf" <mark.langsdorf@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][retry 2] Make x86_64 swiotlb code to support dma_ops [2/2]
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Fri, 02 Mar 2007 09:28:01 +0000
Delivery-date: Fri, 02 Mar 2007 01:28:19 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1449F58C868D8D4E9C72945771150BDFD9669B@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1449F58C868D8D4E9C72945771150BDFD9669B@xxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>The second patch modifies 
>arch/x86_64/kernel/pci-swiotlb-xen.c to work with 
>dma_ops, and modifies arch/x86_64/kernel/pci-dma-xen.c
>slightly to be Xen-safe by copying over some functions
>from arch/i386/kernel/pci-dma-xen.c

The removal of sync_single_range_for_{cpu,device} from swiotlb_dma_ops
cannot work in my opinion, as this is not a no-op. You will need to either
touch Xen's swiotlb.c to add this function, or clone the i386 stubs that map
dma_sync_single_range_for_ to dma_sync_single_for_ (perhaps into an
'else if' in the existing functions in asm-x86_64/mach-xen/asm/dma-mapping.h.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>