RE: [Xen-devel] [PATCH] Make x86_64 swiotlb code to support dma_ops [2/2]

["Jan Beulich" <jbeulich@xxxxxxxxxx>]

>> I'm not sure how far we'll need to deviate -- I
>> suspect we'll end up with a file that look much like the 
>> i386/pci-dma-xen.c
>> but with calls to swiotlb_xxx() replaced with dma_ops->xxx. 
>> Maybe we could
>> even stick with just i386/pci-dma-xen.c and macro up the uses of
>> swiotlb_xxx() (so that they can be replaced with uses of 
>> dma_ops->xxx for x86/64 by cpp).
>
>Given that pci-dma-xen for x86_64 is always going to have 
>most of the functions replaced by either SWIOTLB or an
>IOMMU, would it be sufficient to copy the (known good)
>implementations of dma_alloc_coherent() from the i386
>version?

That is what I would have preferred from the beginning. I just didn't
complain because native lib/swiotlb.c also has these, and I think
they're not very difficult to fix (and also because I was afraid I
already complained about too many other things).

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel