WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH][TOOLS] Reducing impactofdomainsave/restore/dump

To: "Keir Fraser" <keir@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH][TOOLS] Reducing impactofdomainsave/restore/dump on Dom0
From: "Graham, Simon" <Simon.Graham@xxxxxxxxxxx>
Date: Fri, 23 Feb 2007 13:23:45 -0500
Delivery-date: Fri, 23 Feb 2007 10:23:01 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcdO73yfygbdSnxbR/2AnMRpBcbdNgAy2MewAXo9PloACVlAIAAAS21yAGSDywAAAszgRQAD8etA
Thread-topic: [Xen-devel] [PATCH][TOOLS] Reducing impactofdomainsave/restore/dump on Dom0

> Looks better. What is the -D_GNU_SOURCE for? It should probably at
> least be
> limited to CFLAGS-$(CONFIG_Linux). And is it really needed in
> xcutil/Makefile as well: if it's needed at all it should suffice to
use
> it
> when building the library that xcutil links against I would have
> thought?

1. You need _GNU_SOURCE to get posix_fadvise64 defined. I'm happy to
make
   the CFLAGS change (now that I know this facility exists ;-)

2. You need it in xcutil because this directory has code that includes
   xc_private.h -- this seems wrong/bad to me but I wasn't prepared
   to change it!

Simon

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>