WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] Use lib/swiotlb code for x86_64 SWIOTLB

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: RE: [Xen-devel] [PATCH] Use lib/swiotlb code for x86_64 SWIOTLB
From: "Langsdorf, Mark" <mark.langsdorf@xxxxxxx>
Date: Wed, 21 Feb 2007 18:09:34 -0600
Delivery-date: Wed, 21 Feb 2007 16:09:08 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <45D57BD5.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1449F58C868D8D4E9C72945771150BDFD9660C@xxxxxxxxxxxxxxxxx> <C1FAA494.20DC%Keir.Fraser@xxxxxxxxxxxx> <45D57BD5.76E4.0078.0@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcdRpdUBpZL8GnsOSIWI8Pw664F57gEb2uJg
Thread-topic: [Xen-devel] [PATCH] Use lib/swiotlb code for x86_64 SWIOTLB
> I can't see how this can work: First, the way the change is 
> done i386 will also use that file (and then
> arch/i386/kernel/swiotlb.c should also be deleted by
> the patch).

That wasn't intentional.  i386 can still use the 
arch/i386 code.

> Second, there's nothing Xen specific anymore in that file, not
> even the contiguous region creation (the sole difference to 
> plain 2.6.20 is the use of virt_to_bus/bus_to_virt). I think
> the first patch should be really just a move of
> arch/i386/kernel/swiotlb.c to lib/swiotlb-xen.c, nothing else.

This should be an improved version of lib/swiotlb.c as 
lib/swiotlb-xen.c, with correct code to make the mappings
contiguous.

-Mark Langsdorf
AMD, Inc.

Attachment: lib-swiotlb-on-x86_64.patch
Description: lib-swiotlb-on-x86_64.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel